Fix a ractor scheduling issue #12520
Open
+28
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue occurs when there are multiple ractors and threads within those ractors. When an SNT finishes with a thread and the ractor global run queue (grq) is non-empty, make sure the next thread's ractor is enqueued before switching back to native context. Before this change, this did not always occur and could all SNTs sleeping on dequeuing an empty grq when there was work left. Fixes [Bug #20905]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue occurs when there are multiple ractors and threads within those ractors. When an SNT finishes with a thread and the ractor global run queue (grq) is non-empty, make sure the next thread's ractor is enqueued before switching back to native context. Before this change, this did not always occur and could all SNTs sleeping on dequeuing an empty grq when there was work left.
Fixes [Bug #20905]