Show the class variable name which caused a RactorIsolationError #13236
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Class variable (@@var) access is prohibited in non-main Ractors and causes a RactorIsolationError. Currently, RactorIsolationErrors do not carry any information about the actual class variable access which caused the violation. This makes it hard to debug non-Ractor-compatible code, especially when the culprit is in the middle of a long line. This patch adds the class variable name which triggered the RactorIsolationError into its message. This follows the pattern of the "can not access non-shareable objects in constant FOO" error.
|
Example: BeforeAfterError originating here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Class variable (
@@var) access is prohibited in non-main Ractors and causes a RactorIsolationError.Currently, RactorIsolationErrors do not carry any information about the actual class variable access which caused the violation. This makes it hard to debug non-Ractor-compatible code, especially when the culprit is in the middle of a long line.
This patch adds the class variable name which triggered the RactorIsolationError into its message. This follows the pattern of the "can not access non-shareable objects in constant FOO" error.