ZJIT: Parse opt_newarray_send into HIR #13242
Merged
+80
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fast path that can avoid heap-allocating an intermediate Array by using values on the stack.
tekknolagi
commented
May 2, 2025
| @@ -816,6 +835,8 @@ impl Function { | |||
| ArrayDup { val , state } => ArrayDup { val: find!(*val), state: *state }, | |||
| CCall { cfun, args, name, return_type } => CCall { cfun: *cfun, args: args.iter().map(|arg| find!(*arg)).collect(), name: *name, return_type: *return_type }, | |||
| Defined { .. } => todo!("find(Defined)"), | |||
| NewArray { elements, state } => NewArray { elements: find_vec!(*elements), state: find!(*state) }, | |||
There was a problem hiding this comment.
This is an extant bug that I noticed and fixed on the way
tekknolagi
commented
May 2, 2025
| {} | ||
| Insn::ArrayMax { elements, state } | ||
| | Insn::NewArray { elements, state } => { |
There was a problem hiding this comment.
This is an extant bug that I noticed and fixed on the way
k0kubun
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fast path that can avoid heap-allocating an intermediate Array
by using values on the stack.