Add misc/tsan_suppressions.txt #13326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a suppressions file for ThreadSanitizer. Which should help us find and reduce the number of thread safety issues.
So far I've only been testing this against btest, and it is not down to zero failures yet (there's a little bit of randomness in the results as well). However this is at the point that I think it's useful to share, start tracking, and work to reduce the size of the list (maybe eventually have a CI job 🤞).
As I describe in the file, a lot of the issues here are likely benign (the behaviour is fine) or dormant (the compiler happens to generate correct code, but isn't guaranteed to be cause we didn't use atomics). Others are showing us (possibly rare) bugs. We should aim to fix all of these. The ThreadSanitizer wiki has some helpful examples of some common data races https://github.com/google/sanitizers/wiki/ThreadSanitizerPopularDataRaces