Add shape_id to RBasic under 32 bit #13341
Open
+53
−206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
96f185e to
9755585
Compare
eregon
reviewed
May 21, 2025
| #if RBASIC_SHAPE_ID_FIELD | ||
| RBASIC(obj)->shape_id = 0; | ||
| #endif | ||
| } |
There was a problem hiding this comment.
Since this is added, how about adding RBASIC_FLAGS & RBASIC_SET_FLAGS as in oracle/truffleruby#3118 (comment) ?
That would help reduce the amount of direct accesses to that field, and could add extra asserts (e.g. catching some code trying to set the frozen flag directly), etc.
Should RBASIC_SET_FLAGS(obj, 0) reset the shape too?
eregon
reviewed
May 21, 2025
| @@ -153,4 +166,13 @@ RBASIC_CLASS(VALUE obj) | |||
| return RBASIC(obj)->klass; | |||
| } | |||
|
|
|||
| static inline void | |||
| RBASIC_RESET_FLAGS(VALUE obj) | |||
There was a problem hiding this comment.
Should this be in public headers (it is in the current state of this PR) or under internal/**/*.h?
IOW, do you think any C extension would need this, or just CRuby .c files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Feature #21353]
This adds a separate VALUE-sized shape_id field for 32-bit platforms. Allowing them to work much more similarly to how shapes always being available on 64-bit.
This does increase the size of objects by 4 bytes on 32 bit platforms, but shape access should be faster, more consistent, of the same size (32 bits) and much simpler.