Disable GC when building id2ref table #13346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building that table will likely malloc several time which can trigger GC and cause race condition by freeing objects that were just added to the table. Disabling GC to prevent the race condition isn't elegant, but iven this is a deprecated callpath that is executed at most once per process, it seems acceptable.
peterzhu2118
approved these changes
May 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building that table will likely malloc several time which can trigger GC and cause race condition by freeing objects that were just added to the table.
Disabling GC to prevent the race condition isn't elegant, but iven this is a deprecated callpath that is executed at most once per process, it seems acceptable.
Hoping this will fix http://ci.rvm.jp/results/master@oci-aarch64/5755835 (FYI @ko1)