Fix rb_gc_impl_copy_finalizer
#13350
Conversation
casperisfine
commented
May 15, 2025
- Add missing VM_LOCK
- Generate a new object_id when copying finalizers
- Dup the finalizer entry so adding a finalizer on a cloned object doesn't impact the source object.
| assert_in_out_err(["-e", <<-END], "", %w(:ok :ok :ok :ok), []) | ||
| assert_in_out_err(["-e", <<-END], "", %w(:ok :ok :ok), []) |
There was a problem hiding this comment.
My understanding is that this assertion was incorrect.
- We define 1 finalizer on the source object
- Clone the source object, so 1+1 => 2
- Add another finalizer on the copied object, so 2 + 1 => 3.
❌ Tests Failed✖️2 tests failed ✔️61516 tests passed(2 flakes) 22/161 test sessions failed❌ Test session #4321615 failed ❌ Test session #4321617 failed ❌ Test session #4321620 failed ❌ Test session #4321625 failed ❌ Test session #4321626 failed ❌ Test session #4321628 failed ❌ Test session #4321629 failed ❌ Test session #4321638 failed ❌ Test session #4321640 failed ❌ Test session #4321644 failed ❌ Test session #4321647 failed ❌ Test session #4321650 failed ❌ Test session #4321655 failed ❌ Test session #4321661 failed ❌ Test session #4321662 failed ❌ Test session #4321680 failed ❌ Test session #4321693 failed ❌ Test session #4321698 failed ❌ Test session #4321707 failed ❌ Test session #4321798 failed ❌ Test session #4321825 failed ❌ Test session #4321833 failed |
c082a98 to
fdf9e04
Compare
Fix a regression introduced by: ruby#13155
fdf9e04 to
60f41e2
Compare