ZJIT: Split Send into Lookup+Call #13400
Open
+724
−502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will absolutely be cleaning up the commits in this PR for rebasing |
|
Also, I need to figure out some stuff before landing like a codegen implementation of |
|
Is it intentional that the ZJIT CI is failing at the moment? |
|
Well it's not exactly intentional but I don't have codegen for CallMethod because I can't figure out a way to do it yet :( It's currently crashing/assert failing/... |
|
But if you have feedback on the rest of the (admittedly big, kind of disorganized) PR separate from that, I would be interested. The CallMethod codegen is hopefully separate/isolated enough |
❌ Tests Failed✖️no tests failed ✔️61990 tests passed(1 flake) |
This helps method lookups get resolved.
9974149 to
9e4b269
Compare
* Need to spill receiver and arguments to the VM stack as arguments * Don't use cpush; cpush always pushes two words * Save SP * Align stack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split
SendWithoutBlock{,Direct}intoLookupMethodandCallMethod. From there,centralize the profile- and type-driven rewrites to one function:
optimize_lookup_method. This determines if we know the call target at compiletime.
Then, we can rewrite
CallMethodto do something with a known-constant target.If we know it at compile-time, we can specialize to
CallCFuncorCallIseq(or more, like a hypothetical
GetInstanceVariable, in the future).Also,
Fixes Shopify#577
Co-authored-by: Aaron Patterson [email protected]