ZJIT: Stop loading an extra parameter #13719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Tests Failed✖️no tests failed ✔️61818 tests passed(1 flake) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on: #13529
This PR fixes
gen_method_params()to avoid loading one extra parameter. While we added a new basic block argument, we didn't decrementnum_paramsatgen_method_params(). As a result, even if an ISEQ has no argument,num_paramsbecomes 1 and we load a parameter that doesn't exist.Currently, many btests are failing on
tool/fake.rbloaded by the bootstraptest runner because<main>assumes EP == BP for loading a first parameter that doesn't exist on<main>. So fixing this makes a lot more tests pass.