Implements [Feature #21455] Add a block argument to Array#join #13731
+32
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you would like this to be considered, please submit a feature request on https://bugs.ruby-lang.org/, explaining what you see as the costs and benefits of the feature, and linking to this pull request. |
46f2418 to
ca0a3d9
Compare
I sometimes come across code like this where
the `Array#join` at the end can easily
be overlooked or stands out like a sore thumb:
```ruby
hex_string = string.bytes.map do |byte|
format('%02X', byte)
end.join(' ')
```
It seems idiomatic and more succinct
to pass the block to `Array#join` directly:
```ruby
hex_string = string.bytes.join(' ') do |byte|
format('%02X', byte)
end
```
ca0a3d9 to
f69464a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I sometimes come across code like this where
the
Array#joinat the end can easilybe overlooked or stands out like a sore thumb:
It seems idiomatic and more succinct
to pass the block to
Array#joindirectly: