Thanks to visit codestin.com
Credit goes to github.com

Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 42 additions & 1 deletion test/ruby/test_zjit.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1599,7 +1599,7 @@ def test(c) = c.foo
}, call_threshold: 2, insns: [:opt_send_without_block]
end

def test_attr_accessor
def test_attr_accessor_getivar
assert_compiles '[4, 4]', %q{
class C
attr_accessor :foo
Expand All @@ -1615,6 +1615,47 @@ def test(c) = c.foo
}, call_threshold: 2, insns: [:opt_send_without_block]
end

def test_attr_accessor_setivar
assert_compiles '[5, 5]', %q{
class C
attr_accessor :foo

def initialize
@foo = 4
end
end

def test(c)
c.foo = 5
c.foo
end

c = C.new
[test(c), test(c)]
}, call_threshold: 2, insns: [:opt_send_without_block]
end

def test_attr_writer
assert_compiles '[5, 5]', %q{
class C
attr_writer :foo

def initialize
@foo = 4
end

def get_foo = @foo
end

def test(c)
c.foo = 5
c.get_foo
end
c = C.new
[test(c), test(c)]
}, call_threshold: 2, insns: [:opt_send_without_block]
end

def test_uncached_getconstant_path
assert_compiles RUBY_COPYRIGHT.dump, %q{
def test = RUBY_COPYRIGHT
Expand Down
64 changes: 64 additions & 0 deletions zjit/src/hir.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1892,6 +1892,24 @@ impl Function {
}
let getivar = self.push_insn(block, Insn::GetIvar { self_val: recv, id, state });
self.make_equal_to(insn_id, getivar);
} else if def_type == VM_METHOD_TYPE_ATTRSET && args.len() == 1 {
self.push_insn(block, Insn::PatchPoint { invariant: Invariant::MethodRedefined { klass, method: mid, cme }, state });
if let Some(profiled_type) = profiled_type {
recv = self.push_insn(block, Insn::GuardType { val: recv, guard_type: Type::from_profiled_type(profiled_type), state });
}
let id = unsafe { get_cme_def_body_attr_id(cme) };

// Check if we're accessing ivars of a Class or Module object as they require single-ractor mode.
// We omit gen_prepare_non_leaf_call on gen_setivar, so it's unsafe to raise for multi-ractor mode.
if unsafe { rb_zjit_singleton_class_p(klass) } {
let attached = unsafe { rb_class_attached_object(klass) };
if unsafe { RB_TYPE_P(attached, RUBY_T_CLASS) || RB_TYPE_P(attached, RUBY_T_MODULE) } {
self.push_insn(block, Insn::PatchPoint { invariant: Invariant::SingleRactorMode, state });
}
}
let val = args[0];
let setivar = self.push_insn(block, Insn::SetIvar { self_val: recv, id, val, state });
self.make_equal_to(insn_id, setivar);
} else {
if let Insn::SendWithoutBlock { def_type: insn_def_type, .. } = &mut self.insns[insn_id.0] {
*insn_def_type = Some(MethodType::from(def_type));
Expand Down Expand Up @@ -9659,4 +9677,50 @@ mod opt_tests {
Return v17
");
}

#[test]
fn test_inline_attr_accessor_set() {
eval("
class C
attr_accessor :foo
end

def test(o) = o.foo = 5
test C.new
test C.new
");
assert_snapshot!(hir_string("test"), @r"
fn test@<compiled>:6:
bb0(v0:BasicObject, v1:BasicObject):
v6:Fixnum[5] = Const Value(5)
PatchPoint MethodRedefined(C@0x1000, foo=@0x1008, cme:0x1010)
v15:HeapObject[class_exact:C] = GuardType v1, HeapObject[class_exact:C]
SetIvar v15, :@foo, v6
CheckInterrupts
Return v6
");
}

#[test]
fn test_inline_attr_writer_set() {
eval("
class C
attr_writer :foo
end

def test(o) = o.foo = 5
test C.new
test C.new
");
assert_snapshot!(hir_string("test"), @r"
fn test@<compiled>:6:
bb0(v0:BasicObject, v1:BasicObject):
v6:Fixnum[5] = Const Value(5)
PatchPoint MethodRedefined(C@0x1000, foo=@0x1008, cme:0x1010)
v15:HeapObject[class_exact:C] = GuardType v1, HeapObject[class_exact:C]
SetIvar v15, :@foo, v6
CheckInterrupts
Return v6
");
}
}
Loading