Only set ME cached flag when unset #14631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The same method entry may be reused in multiple caches, so once the CACHED flag is set, other Ractors may be checking for it being invalidated and we should avoid writing to the field again. I believe there are still other race conditions on how we manipulate these flags (particularly the invalidation bit), but this should make them less frequent.
be9250f to
f05100e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The same method entry may be reused in multiple caches, so once the CACHED flag is set, other Ractors may be checking for it being invalidated and we should avoid writing to the field again.
I believe there are still other race conditions on how we manipulate these flags (particularly the invalidation bit), but this should make them less frequent.