gc_validate_pc(): Exclude imemos; add a test and a hint in assert message #14635
+37
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would also like to change the ZJIT optimizer to not allocate at compile-time. What is the best replacement method? |
5c6e1fc to
eec071c
Compare
|
In this case the allocation was happening at runtime though, through But all lookup methods do caching in some way so all allocate. We kind of just have to deal with it unless we want to move out of using CMEs wholesale, not realistic. |
The validation is relevant only for traceable userland ruby objects ruby code could interact with. ZJIT's use of rb_vm_method_cfunc_is() allocates a CC imemo and was failing this validation when it was actually fine. Relax the check.
eec071c to
376f8c4
Compare
❌ Tests Failed✖️no tests failed ✔️62248 tests passed(3 flakes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The validation is relevant only for traceable userland ruby objects ruby code could interact with. ZJIT's use of
rb_vm_method_cfunc_is()allocates a CC imemo and was failing this validation when it was actually fine. Relax the check.