Fix misleading NoMatchingPatternKeyError when destructuring Data, Struct, and MatchData
#15748
+116
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoMatchingPatternKeyError when destructuring Data, Struct, and MatchData**NoMatchingPatternKeyError when destructuring Data, Struct, and MatchData
4db3068 to
a892f1c
Compare
Fixes Bug #21805. Improved deconstruct_keys behavior to return all found keys instead of failing early or returning an empty hash when more keys are requested than the object contains. Modified files: - struct.c: Fix rb_struct_deconstruct_keys - re.c: Fix match_deconstruct_keys - test/ruby/test_data.rb: Update tests - test/ruby/test_regexp.rb: Update tests - spec/ruby/core/data/deconstruct_keys_spec.rb: Update specs - spec/ruby/core/struct/deconstruct_keys_spec.rb: Update specs - spec/ruby/core/matchdata/deconstruct_keys_spec.rb: Update specs
a892f1c to
09cb6da
Compare
…dle edge cases with non-existing keys and attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Bug #21805 where destructuring a
Dataobject (orStruct/MatchData) with a pattern containing missing keys would report an existing key as missing.