ZJIT: x64: Prefer 7-byte sign extending mov over 10-byte movabs#16992
Open
XrXr wants to merge 1 commit into
Open
ZJIT: x64: Prefer 7-byte sign extending mov over 10-byte movabs#16992XrXr wants to merge 1 commit into
mov over 10-byte movabs#16992XrXr wants to merge 1 commit into
Conversation
Relevant for small negative immediates. Previously: # Insn: v16 SetLocal l1, EP@3, v10 mov rsi, qword ptr [r13 + 0x20] mov rsi, qword ptr [rsi - 8] and rsi, 0xfffffffffffffffc # call rb_vm_env_write push rdi push rdi mov rdx, rdi mov rdi, rsi movabs rsi, 0xfffffffffffffffd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant for small negative immediates. Previously:
+patch/master code_region_bytes ratio = 12,029,952 / 12,136,448 ~= 0.991 on a default 25 iteration run of
lobsterson ruby/ruby-bench.