ZJIT: Split test_dont_inline_integer_xor_with_bignum_or_boolean#16993
Open
k0kubun wants to merge 1 commit into
Open
ZJIT: Split test_dont_inline_integer_xor_with_bignum_or_boolean#16993k0kubun wants to merge 1 commit into
k0kubun wants to merge 1 commit into
Conversation
When a single #[test] function holds multiple assert_snapshot! calls, only the first one is updated per cargo-insta run, so updating all of them takes multiple zjit-test -> zjit-test-update cycles. Splitting into one snapshot per test lets a single cycle update them all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits
test_dont_inline_integer_xor_with_bignum_or_booleaninto three tests.Having multiple
assert_snapshots!in a single test function means that you need to run multiple runs ofzjit-test+zjit-test-updateloops. This function has three pairs of Ruby code + HIR test, so there's no good reason to group them in the same test function.