Enhanced RDoc for String#succ #3590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeremyevans, the penultimate collection of examples are not what I expected. Rollover seems not to pass through 255.chr as I'd expected. |
jeremyevans
approved these changes
Sep 25, 2020
string.c
Outdated
| * "ZZZ9999".succ #=> "AAAA0000" | ||
| * "***".succ #=> "**+" | ||
| * string.succ -> new_str | ||
| * string.next -> new_str |
There was a problem hiding this comment.
I think we should leave next off the call-seq, and only mention it near the end as an alias.
There was a problem hiding this comment.
@jeremyevans, the penultimate collection of examples are not what I expected. Rollover seems not to pass through 255.chr as I'd expected. So the text needs to change. I'll draft something.
jeremyevans
approved these changes
Sep 25, 2020
ioquatix
pushed a commit
to ioquatix/ruby
that referenced
this pull request
Sep 30, 2020
* Enhanced RDoc for String#succ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.