Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Run nmake check on Actions #4487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
May 11, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ jobs:
make:
strategy:
matrix:
test_task: [test]
test_task: [check] # to make job names consistent
os: [windows-2019]
vs: [2019]
fail-fast: false
Expand Down Expand Up @@ -62,10 +62,24 @@ jobs:
nmake extract-extlibs
nmake
- name: nmake test
timeout-minutes: 30
timeout-minutes: 5
run: |
call "%VCVARS%"
nmake ${{ matrix.test_task }}
nmake test
- name: nmake test-all
timeout-minutes: 60
run: |
call "%VCVARS%"
# %TEMP% is inconsistent with %TMP% and test-all expects they are consistent.
# https://github.com/actions/virtual-environments/issues/712#issuecomment-613004302
set TMP=%USERPROFILE%\AppData\Local\Temp
set TEMP=%USERPROFILE%\AppData\Local\Temp
nmake test-all
- name: nmake test-spec
timeout-minutes: 10
run: |
call "%VCVARS%"
nmake test-spec
- uses: k0kubun/[email protected]
with:
payload: |
Expand Down
1 change: 1 addition & 0 deletions spec/ruby/optional/capi/rbasic_spec.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
require_relative 'spec_helper'
require_relative 'shared/rbasic'
load_extension("rbasic")
return if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning
load_extension("data")
load_extension("array")

Expand Down
1 change: 1 addition & 0 deletions test/resolv/test_dns.rb
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ def test_query_ipv4_address_timeout
end

def test_no_server
skip if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning
u = UDPSocket.new
u.bind("127.0.0.1", 0)
_, port, _, host = u.addr
Expand Down
1 change: 1 addition & 0 deletions test/ruby/test_file_exhaustive.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1257,6 +1257,7 @@ def test_dirname
assert_equal(regular_file, File.dirname(regular_file, 0))
assert_equal(@dir, File.dirname(regular_file, 1))
assert_equal(File.dirname(@dir), File.dirname(regular_file, 2))
return if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # rootdir and tmpdir are in different drives
assert_equal(rootdir, File.dirname(regular_file, regular_file.count('/')))
assert_raise(ArgumentError) {File.dirname(regular_file, -1)}
end
Expand Down
3 changes: 3 additions & 0 deletions test/rubygems/test_gem_ext_builder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@ def test_custom_make_with_options
end

def test_build_extensions
skip if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning
@spec.extensions << 'ext/extconf.rb'

ext_dir = File.join @spec.gem_dir, 'ext'
Expand Down Expand Up @@ -141,6 +142,7 @@ def test_build_extensions
end

def test_build_extensions_with_gemhome_with_space
skip if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning
new_gemhome = File.join @tempdir, 'gem home'
File.rename(@gemhome, new_gemhome)
@gemhome = new_gemhome
Expand All @@ -161,6 +163,7 @@ def Gem.install_extension_in_lib
false
end
end
skip if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning

@spec.extensions << 'ext/extconf.rb'

Expand Down
1 change: 1 addition & 0 deletions test/rubygems/test_gem_installer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -1482,6 +1482,7 @@ def test_find_lib_file_after_install

def test_install_extension_and_script
skip "Makefile creation crashes on jruby" if Gem.java_platform?
skip if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning

@spec = setup_base_spec
@spec.extensions << "extconf.rb"
Expand Down
1 change: 1 addition & 0 deletions test/rubygems/test_gem_resolver_git_specification.rb
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ def test_install

def test_install_extension
skip if Gem.java_platform?
skip if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning
name, _, repository, = git_gem 'a', 1 do |s|
s.extensions << 'ext/extconf.rb'
end
Expand Down
1 change: 1 addition & 0 deletions tool/test/webrick/test_filehandler.rb
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@ def test_unwise_in_path

def test_short_filename
return if File.executable?(__FILE__) # skip on strange file system
return if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning

config = {
:CGIInterpreter => TestWEBrick::RubyBin,
Expand Down
1 change: 1 addition & 0 deletions tool/test/webrick/test_httpproxy.rb
Original file line number Diff line number Diff line change
Expand Up @@ -323,6 +323,7 @@ def test_connect
end if defined?(OpenSSL::SSL)

def test_upstream_proxy
return if /mswin/ =~ RUBY_PLATFORM && ENV.key?('GITHUB_ACTIONS') # not working from the beginning
# Testing GET or POST through the upstream proxy server
# Note that the upstream proxy server works as the origin server.
# +------+
Expand Down