YJIT: Add RubyVM::YJIT.code_gc #6644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c706b91 to
18967fa
Compare
18967fa to
9581510
Compare
maximecb
reviewed
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be useful when triggering this at the end of initialization is efficient enough and it's more time-consuming to find a good
--yjit-exec-mem-sizethat stabilizes Code GC.Railsbench stats
I checked the impact of calling the
RubyVM::YJIT.code_gcatconfig/initializers/yjit_code_gc.rb(last initializer):YJIT.code_gcIt seems like
config/initializersis still too early for Code GC, but it's still better than never triggering Code GC.P.S. Looks like now
--yjit-exec-mem-size=9is needed to fit all code today (it was 6 in #6406), maybe due to the reduced # of size exits (which is a good thing).