Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Unconditionally warn "unknown pack/unpack directive" #6948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Unconditionally warn "unknown pack/unpack directive" #6948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pack.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,8 @@ unknown_directive(const char *mode, char type, VALUE fmt)
snprintf(unknown, sizeof(unknown), "\\x%.2x", type & 0xff);
}
fmt = rb_str_quote_unprintable(fmt);
rb_warning("unknown %s directive '%s' in '%"PRIsVALUE"'",
mode, unknown, fmt);
rb_warn("unknown %s directive '%s' in '%"PRIsVALUE"'",
mode, unknown, fmt);
}

static float
Expand Down
12 changes: 2 additions & 10 deletions test/ruby/test_pack.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -777,21 +777,13 @@ def test_short_with_block
end

def test_pack_garbage
assert_warn("") do
assert_equal "\000", [0].pack("*U")
end

assert_warning(%r%unknown pack directive '\*' in '\*U'$%) do
assert_warn(%r%unknown pack directive '\*' in '\*U'$%) do
assert_equal "\000", [0].pack("*U")
end
end

def test_unpack_garbage
assert_warn("") do
assert_equal [0], "\000".unpack("*U")
end

assert_warning(%r%unknown unpack directive '\*' in '\*U'$%) do
assert_warn(%r%unknown unpack directive '\*' in '\*U'$%) do
assert_equal [0], "\000".unpack("*U")
end
end
Expand Down