Integrate with lrama #7798
Merged
Integrate with lrama #7798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ary.each do |s| | ||
| s = s.gsub('\\', '\\\\\\\\') | ||
| s = s.gsub('"', '\\"') |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
|
Why |
|
Seems only lrama/version.rb differs. |
ce0f873 to
dadfa7a
Compare
nobu
requested changes
May 12, 2023
template/Makefile.in
Outdated
| @@ -29,7 +29,7 @@ CPP = @CPP@ | |||
| LD = @LD@ | |||
| RUSTC = @RUSTC@ | |||
| CARGO = @CARGO@ | |||
| YACC = bison | |||
| YACC = $(tooldir)/lrama/exe/lrama | |||
There was a problem hiding this comment.
/usr/bin/env shebang trick is not portable.
Suggested change
| YACC = $(tooldir)/lrama/exe/lrama | |
| YACC = $(BASERUBY) $(tooldir)/lrama/exe/lrama |
ext/ripper/depend
Outdated
| @@ -1,6 +1,7 @@ | |||
| GEN = $(srcdir)/tools/generate.rb | |||
| SRC1 = $(top_srcdir)/parse.y | |||
| SRC2 = $(srcdir)/eventids2.c | |||
| BISON = "$(RUBY) $(GEN) $(top_srcdir)/tool/lrama/exe/lrama" | |||
There was a problem hiding this comment.
Suggested change
| BISON = "$(RUBY) $(GEN) $(top_srcdir)/tool/lrama/exe/lrama" | |
| BISON = $(RUBY) $(GEN) $(top_srcdir)/tool/lrama/exe/lrama |
0758e72 to
f654c43
Compare
yui-knk
added a commit
to yui-knk/lrama
that referenced
this pull request
May 17, 2023
After ruby/ruby#7798, ruby uses lrama as default then no need to pass YACC anymore.
hachi8833
added a commit
to hachi8833/ruby_docker_library
that referenced
this pull request
Feb 6, 2024
tianon
pushed a commit
to hachi8833/ruby_docker_library
that referenced
this pull request
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.ruby-lang.org/issues/19637