Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate Kernel#open and IO support for subprocess creation or forking #7915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 10, 2023
Merged

Deprecate Kernel#open and IO support for subprocess creation or forking #7915

merged 1 commit into from
Aug 10, 2023
+165 −180

Conversation

flavorjones
Copy link
Contributor

@flavorjones flavorjones commented Jun 7, 2023 •
edited
Loading

[Feature #19630] / https://bugs.ruby-lang.org/issues/19630

Deprecate Kernel#open and IO support for subprocess creation and
forking. This also deprecates subprocess creation and forking in

  • Kernel#open
  • URI.open
  • IO.binread
  • IO.foreach
  • IO.readlines
  • IO.read
  • IO.write

Example warnings:

IO.read("|echo foo")
> warning: IO process creation with a leading '|' is deprecated and will be removed in Ruby 4.0; use IO.popen instead


open("|echo foo")
> warning: Calling Kernel#open with a leading '|' is deprecated and will be removed in Ruby 4.0; use IO.popen instead

require 'open-uri'
URI.open("|echo foo")
> ruby/3.3.0+0/open-uri.rb:31: warning: Calling Kernel#open with a leading '|' is deprecated and will be removed in Ruby 4.0; use IO.popen instead

nobu
nobu reviewed Jul 14, 2023
View reviewed changes
@flavorjones flavorjones force-pushed the 19630-flavorjones-deprecate-kernel-open-process-control branch 2 times, most recently from 548ce18 to 0a547d2 Compare July 20, 2023 17:55
@flavorjones flavorjones changed the title Deprecate Kernel#open support for subprocess creation or forking Deprecate Kernel#open and IO#open support for subprocess creation or forking Jul 20, 2023
@flavorjones flavorjones changed the title Deprecate Kernel#open and IO#open support for subprocess creation or forking Deprecate Kernel#open and IO support for subprocess creation or forking Jul 22, 2023
@flavorjones flavorjones force-pushed the 19630-flavorjones-deprecate-kernel-open-process-control branch from 0a547d2 to cb63e94 Compare July 24, 2023 20:20
@flavorjones flavorjones requested a review from nobu July 24, 2023 20:25
@flavorjones flavorjones force-pushed the 19630-flavorjones-deprecate-kernel-open-process-control branch from cb63e94 to 2174bfe Compare July 24, 2023 21:06
@hsbt hsbt force-pushed the 19630-flavorjones-deprecate-kernel-open-process-control branch from 2174bfe to 2aeb288 Compare August 4, 2023 07:02
nobu
nobu requested changes Aug 4, 2023
View reviewed changes
nobu
nobu reviewed Aug 8, 2023
View reviewed changes
@flavorjones flavorjones force-pushed the 19630-flavorjones-deprecate-kernel-open-process-control branch from 2aeb288 to 8ccec72 Compare August 8, 2023 14:23
@flavorjones
Deprecate Kernel#open and IO support for subprocess creation/forking
99758e1 
Deprecate Kernel#open and IO support for subprocess creation and
forking. This deprecates subprocess creation and forking in

- Kernel#open
- URI.open
- IO.binread
- IO.foreach
- IO.readlines
- IO.read
- IO.write

This behavior is slated to be removed in Ruby 4.0

[Feature #19630]
@flavorjones flavorjones force-pushed the 19630-flavorjones-deprecate-kernel-open-process-control branch from 8ccec72 to 99758e1 Compare August 8, 2023 14:32
@flavorjones flavorjones requested review from nobu and matz August 8, 2023 15:14
@nobu nobu merged commit d234336 into ruby:master Aug 10, 2023
@flavorjones flavorjones deleted the 19630-flavorjones-deprecate-kernel-open-process-control branch August 10, 2023 02:18
@hsbt hsbt mentioned this pull request Dec 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobu nobu nobu approved these changes

@matz matz matz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flavorjones @nobu @matz