Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[PRISM] Support UTF-8 symbols #9706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 29, 2024
Merged

[PRISM] Support UTF-8 symbols #9706

merged 3 commits into from
Jan 29, 2024

Conversation

peterzhu2118
Copy link
Member

Fixes ruby/prism#2242.

Blocked by ruby/prism#2268.

@peterzhu2118 peterzhu2118 marked this pull request as ready for review January 26, 2024 20:19
kddnewton
kddnewton requested changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@kddnewton kddnewton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you handle FORCED_BINARY_ENCODING and FORCED_US_ASCII_ENCODING as well?

kddnewton
kddnewton requested changes Jan 26, 2024
View reviewed changes
@kddnewton kddnewton merged commit 3d3d9e8 into ruby:master Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kddnewton kddnewton kddnewton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[COMPILER] UTF-8 symbols in us-ascii file
2 participants
@peterzhu2118 @kddnewton