Remove object_id use in Set#inspect
#33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
commented
Dec 18, 2023
| # Returns a string containing a human-readable representation of the | ||
| # set ("#<Set: {element1, element2, ...}>"). | ||
| def inspect | ||
| ids = (Thread.current[InspectKey] ||= Set.new.compare_by_identity) |
There was a problem hiding this comment.
Using an identity Set here matches what pp does:
https://github.com/ruby/ruby/blob/e8064c6c2c317be78953b4d19226368580af0dca/lib/pp.rb#L146-L161
099bd87 to
a045f65
Compare
amomchilov
commented
Dec 18, 2023
| to_a.join(separator) | ||
| end | ||
|
|
||
| def self.__inspect_supports_identity_set? |
There was a problem hiding this comment.
This is checked by the corresponding PR in ostruct:
amomchilov
commented
May 22, 2025
Comment on lines
+821
to
+822
| # We share the same `ids` value as `OpenStruct#inspect`, so we need to use an identity Set | ||
| # only we're using a newer version of the `ostruct` gem which is also using an identity Set. |
There was a problem hiding this comment.
Suggested change
| # We share the same `ids` value as `OpenStruct#inspect`, so we need to use an identity Set | |
| # only we're using a newer version of the `ostruct` gem which is also using an identity Set. | |
| # We share the same thread-local `ids` value as `OpenStruct#inspect`, so we need to use an identity Set | |
| # only when we're using a newer version of the `ostruct` gem which is also using an identity Set. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this while auditing uses of
object_idinruby/ruby. Pulled out from ruby/ruby#9276.This PR replaces look-ups into an Array by
object_ids, with an identity Set (seeSet#compare_by_identity). This has the same semantics but is faster and doesn't trigger allocation of IDs for these objects.On quirk here is that the
Thread.current[:__inspect_key__]value used bySet#inspectis also shared withOpenStruct#inspect. This PR provides two implementations of#inspect, depending on whether or not the matching version of theostructgem is also using an identity set. See ruby/ostruct#58