Update an Enumerable#uniq spec and add Enumerator::Lazy#uniq specs
#448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kachick
commented
Jun 21, 2017
core/enumerable/uniq_spec.rb
Outdated
| end | ||
| end | ||
|
|
||
| ruby_bug '#13669', ''...'2.5' do |
There was a problem hiding this comment.
It will be backported in 2.4.
In the meanwhile it's OK to have this ruby_bug guard.
There was a problem hiding this comment.
OK to have
BTW, Range syntax makes 🔴 😕 https://travis-ci.org/ruby/spec/jobs/245452368
So updated as a satisfied version as fe53279
There was a problem hiding this comment.
''...'2.5' means excluding 2.5, '2.5' means until 2.5 inclusive.
ruby-head in Travis is old (from May), that's why it fails.
There was a problem hiding this comment.
It's a typical synchronization problem.
Maybe I should stop testing against ruby-head or allow failure on Travis,
since MRI already runs ruby/spec on trunk.
eregon
approved these changes
Jun 21, 2017
70 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enumerator::Lazy#uniqspecs asEnumerable#uniq