Print a deprecation warning for chilled strings #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // From internal/string.h | ||
| // Ruby 3.4 introduces "chilled" strings, which behave like frozen strings unless written to. | ||
| // In order to facilitate an easier upgrade path, print a deprecation warning instead of raising. | ||
| #define STR_CHILLED FL_USER3 |
There was a problem hiding this comment.
Yeah, this is a big no no.
I'll see if I can find a better solution.
There was a problem hiding this comment.
Thank you for looking into it. I had an inkling that this might be the case.
There was a problem hiding this comment.
Here's my solution: #93
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ruby/ruby#10262 (comment)
As far as I can tell, since this isn't exposed there is no good way to actually get this information "officially". I'm not very familiar with programming ruby itself and even less familiar with C.
If there is a better way to do this, feel free to take over.
cc @casperisfine