The local part should not contain leading or trailing dots in the EMAIL_REGEXP #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leading or trailing dots
…l part instead of a character class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, I'd like to thank all the contributors for their time and effort.
Recently, I've noticed that the EMAIL_REGEXP constant fails to handle a situations where there are leading or trailing dots in the local part of an email address. It's worth noting that while all major email providers permit the use of dots between characters, they prohibit their placement at the beginning or end of the local part.
I didn't find the exact information about the leading and trailing dots in the RFCs (5321, 5322). However, I believe it's practically useful to specify them in the regex.
Examples of an invalid email:
[email protected][email protected]