This repository was archived by the owner on Oct 19, 2018. It is now read-only.
Fix Fixnum Bignum deprecation warning #220
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ruby 2.4 unifies Fixnum and Bignum into Integer and prints a warning if the old constants are accessed. hyper-react causes this warning to be printed on boot: ``` lib/reactive-ruby/serializers.rb:1: warning: constant ::Bignum is deprecated lib/reactive-ruby/serializers.rb:1: warning: constant ::Fixnum is deprecated ``` I've fixed this in the [same way as Rails](https://github.com/jeremy/rails/blob/b9bda7fd891147a0bc0cffa6dd9d15601be8b472/activesupport/lib/active_support/core_ext/numeric/conversions.rb#L131) to support both older and newer versions of Ruby.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.4 unifies Fixnum and Bignum into Integer and prints a warning if the old constants are accessed. hyper-react causes this warning to be printed on boot:
I've fixed this in the same way as Rails to support both older and newer versions of Ruby.