Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make RBNF fall back to root #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make RBNF fall back to root #257

wants to merge 2 commits into from

Conversation

c960657
Copy link
Contributor

@c960657 c960657 commented Nov 1, 2023

The RBNF for individual locales do not fall back to root. This is wrong. In particular, many locales rely on digits-ordinal being inherited from root.

The format currently exported by Rbnf is not suitable for merging. This PR suggests a different format. I do not have strong opinions on the specific format.

I am not sure about the intention behind Rbnf. I assume it is to avoid duplicating NumberingSystemRules in every locale. My patch is based on this assumption.

The output in xx/rbnf.yml looks like this:

---
da:
  rbnf:
    grouping:
      ordinal_rules:
        digits-ordinal:
          rules:
            "-x":
              rule: "−>>;"
            '0':
              rule: "=#,##0=.;"
      spellout_rules:
        and-small:
          access: private
          rules:
            '0':
              rule: og =%spellout-cardinal-common=;
            '100':
              rule: "=%spellout-cardinal-common=;"

The output in rbnf_root.yml looks like this:

---
rbnf:
  grouping:
    numbering_system_rules:
      cyrillic-lower-post:
        rules:
          '0':
            rule: ҃;
          '1':
            rule: "=%cyrillic-lower=;"
        access: private
      armenian-lower:
        rules:
          "-x":
            rule: "−>>;"
          x.x:
            rule: "=#,##0.00=;"
          '0':
            rule: 0;
          '1':
            rule: ա;

@c960657 c960657 mentioned this pull request Nov 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@c960657