Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix CI against JRuby, JRuby-head, and Windows #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix CI against JRuby, JRuby-head, and Windows #630

wants to merge 1 commit into from

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Jan 8, 2025 •
edited
Loading

Additionally:

  • Use latest rubygems, instead of specifying a version and keeping
    it up to date
  • Bump rake dependency to ~> 13.2.0 to allow tests to pass against
    Windows

@coveralls
Copy link

coveralls commented Jan 8, 2025 •
edited
Loading

Coverage Status

coverage: 96.992%. first build
when pulling 5455471 on tagliala:chore/fix-jruby-specs
into 8ed6662 on rubyzip:master.

@tagliala
Copy link
Contributor Author

tagliala commented Jan 8, 2025 •
edited
Loading

This is fixing both jruby and jruby-head (but they can randomly fail). Failures on windows caused by missing ostruct?

@Earlopain
Copy link

You need to allow newer rake to fix that

@tagliala tagliala force-pushed the chore/fix-jruby-specs branch from 4a352f0 to 283f088 Compare January 11, 2025 10:20
@tagliala
Fix CI against JRuby, JRuby-head, and Windows
5455471 
Additionally:
- Use `latest` rubygems, instead of specifying a version and keeping
  it up to date
- Bump `rake` dependency to `~> 13.2.0` to allow tests to pass against
  Windows
@tagliala tagliala force-pushed the chore/fix-jruby-specs branch from 283f088 to 5455471 Compare January 11, 2025 10:21
@tagliala tagliala changed the title Fix CI against JRuby and JRuby-head Fix CI against JRuby, JRuby-head, and Windows Jan 11, 2025
@tagliala
Copy link
Contributor Author

tagliala commented Jan 11, 2025 •
edited
Loading

You need to allow newer rake to fix that

Thanks, I actually did not notice that stable development gems are locked at patch level (and non-stable are locked at minor level).

It looks pretty unusual to me (except for rubocop). I wonder why if a new PR should be proposed to relax the dependencies for stable libraries following semver (is rake following semver? there are no references in the code)

@tagliala tagliala marked this pull request as draft January 24, 2025 16:01
@tagliala
Copy link
Contributor Author

JRuby 9.4.10.0 has been released

However:

@tagliala tagliala marked this pull request as ready for review January 24, 2025 16:08
@tagliala tagliala force-pushed the chore/fix-jruby-specs branch from 2330f0b to 5455471 Compare January 24, 2025 16:08
@hainesr
Copy link
Member

hainesr commented Jan 25, 2025

Thank you for your work on this.

I have relaxed the gem dependencies and merged this pull request on top of that, and it looks like it has worked!

(Closing this manually.)

@hainesr hainesr closed this Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tagliala @coveralls @Earlopain @hainesr