Thanks to visit codestin.com
Credit goes to github.com

Skip to content

try python in ci #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 22, 2025
Merged

try python in ci #298

merged 4 commits into from
Aug 22, 2025

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Jun 7, 2025

Hello, thanks for rudof!

In trying to package this (specifically pyrudof) for conda-forge, I ran into some issues.

This tries running the python test suite in CI, hopefully to demonstrate something like:

test_ko (python.tests.test_shacl.TestShacl.test_ko) ... ERROR
test_ok (python.tests.test_shacl.TestShacl.test_ok) ... ERROR

======================================================================
ERROR: test_ko (python.tests.test_shacl.TestShacl.test_ko)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "~/rudof/python/tests/test_shacl.py", line 45, in test_ko
    result = rudof.validate_shacl(ShaclValidationMode(), ShapesGraphSource())
                                  ~~~~~~~~~~~~~~~~~~~^^
TypeError: No constructor defined for ShaclValidationMode

======================================================================
ERROR: test_ok (python.tests.test_shacl.TestShacl.test_ok)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "~/rudof/python/tests/test_shacl.py", line 24, in test_ok
    result = rudof.validate_shacl(ShaclValidationMode(), ShapesGraphSource())
                                  ~~~~~~~~~~~~~~~~~~~^^
TypeError: No constructor defined for ShaclValidationMode

----------------------------------------------------------------------
Ran 2 tests in 0.001s

@bollwyvl bollwyvl marked this pull request as ready for review June 7, 2025 14:02
@bollwyvl bollwyvl force-pushed the python-ci branch 4 times, most recently from 8eebe96 to 56f8074 Compare June 7, 2025 14:40
@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jun 7, 2025

After a few false starts, here is a run that demonstrates the issue:

https://github.com/bollwyvl/rudof/actions/runs/15508853162/job/43667091672

@bollwyvl
Copy link
Contributor Author

bollwyvl commented Jun 7, 2025

Here's a run with more representative errors on various VMs:
https://github.com/bollwyvl/rudof/actions/runs/15509018417

@labra
Copy link
Member

labra commented Aug 21, 2025

Thanks a lot for your PR and my apologies for not looking to it until now.

I was looking to the PR now and I am not sure if you think it can already be merged into master or if it still needs more work.

I am not an expert neither in Python or Github workflows so I am not sure if what you provided is working or just a draft because you sent some links to things that are failing (but maybe that's what you wanted to show?).

If you think the PR is already working I can merge it.

In any case, thanks a lot for your interest in rudof!

@bollwyvl
Copy link
Contributor Author

Thanks!

I think the plumbing is all sound, but the underlying issue (and seen in the examples) is that there is some discrepancy between the stated API in the tests and examples and what actually works. Having these working would make it much easier to confidently package downstream.

@labra
Copy link
Member

labra commented Aug 22, 2025

OK, I tried it in a local branch and there were some errors in the test_shacl.py that I was able to repair, and now it works at least in linux. I will merge it and continue from master to see if we can repair them...

@labra labra merged commit e794cef into rudof-project:master Aug 22, 2025
@labra labra mentioned this pull request Aug 22, 2025
Open
@bollwyvl
Copy link
Contributor Author

Great, thanks!

@bollwyvl bollwyvl deleted the python-ci branch August 22, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bollwyvl @labra