Thanks to visit codestin.com
Credit goes to github.com

Skip to content

avm2: Implement clone() method for flash.text.engine classes #21592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

avm2: Implement clone() method for flash.text.engine classes #21592

wants to merge 3 commits into from

Conversation

onkrot
Copy link
Contributor

@onkrot onkrot commented Sep 7, 2025 •
edited
Loading

The original issue was found while testing the gui demo from alternativa demos package

Error dispatching event EventObject { type: "addedToStage", class: flash.events::Event, ptr: 0x22d629be5d0 } to handler FunctionObject { ptr: 0x1ed52eccee0, name: "Main/init()" } : ReferenceError: Error #1069: Property clone not found on flash.text.engine.ElementFormat and there is no default value.
        at alternativa.gui.controls.text::Label/set size()
        at alternativa.gui.theme.defaulttheme.controls.text::Label()
        at alternativa.gui.theme.defaulttheme.controls.dropDownMenu::DropDownMenuTopButton/init()
        at alternativa.gui.controls.dropDownMenu::DropDownMenuTopButton()
        at alternativa.gui.theme.defaulttheme.controls.dropDownMenu::DropDownMenuTopButton()
        at alternativa.gui.controls.dropDownMenu::DropDownMenu/set dataProvider()
        at ContainerSample()
        at Main/init()
        at flash.display::DisplayObjectContainer/addChild()
        at Preloader/startup()
        at Preloader/loadingFinished()
        at Preloader/checkFrame()

@onkrot onkrot changed the title Implement clone() method for flash.text.engine classes avm2: Implement clone() method for flash.text.engine classes Sep 7, 2025
@danielhjacobs danielhjacobs added A-avm2 Area: AVM2 (ActionScript 3) T-compat Type: Compatibility with Flash Player labels Sep 8, 2025
@evilpie evilpie added the waiting-on-review Waiting on review from a Ruffle team member label Sep 9, 2025
@Lord-McSweeney Lord-McSweeney self-requested a review September 11, 2025 04:40
Lord-McSweeney
Lord-McSweeney reviewed Sep 15, 2025
View reviewed changes
Lord-McSweeney
Lord-McSweeney reviewed Sep 15, 2025
View reviewed changes
@Lord-McSweeney Lord-McSweeney added waiting-on-author Waiting on the PR author to make the requested changes and removed waiting-on-review Waiting on review from a Ruffle team member labels Sep 15, 2025
@Lord-McSweeney Lord-McSweeney removed the waiting-on-author Waiting on the PR author to make the requested changes label Sep 17, 2025
Lord-McSweeney
Lord-McSweeney reviewed Sep 17, 2025
View reviewed changes
core/src/avm2/globals/flash/text/engine/EastAsianJustifier.as
public function EastAsianJustifier(locale:String = "ja", lineJustification:String = "allButLast", justificationStyle:String = "pushInKinsoku") {
super(locale, lineJustification);
this.justificationStyle = justificationStyle;
this._justificationStyle = justificationStyle;
Copy link
Collaborator

@Lord-McSweeney Lord-McSweeney Sep 17, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for this change? Doing it this way means we'd need to duplicate the validation logic for justificationStyle in the future

Lord-McSweeney
Lord-McSweeney reviewed Sep 17, 2025
View reviewed changes
core/src/avm2/globals/flash/text/engine/TextJustifier.as
this.locale = locale;
this.lineJustification = lineJustification;
this._locale = locale;
this._lineJustification = lineJustification;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too, for lineJustification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lord-McSweeney Lord-McSweeney Lord-McSweeney left review comments

Assignees
No one assigned
Labels
A-avm2 Area: AVM2 (ActionScript 3) T-compat Type: Compatibility with Flash Player
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@onkrot @Lord-McSweeney @evilpie @danielhjacobs