Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@kjarosh
Copy link
Member

@kjarosh kjarosh commented Dec 14, 2025

This patch stubs:

  • flash.automation.Configuration,
  • flash.automation.ActionGenerator,
  • flash.automation.StageCapture.

@kjarosh kjarosh added A-avm1 Area: AVM1 (ActionScript 1 & 2) T-compat Type: Compatibility with Flash Player waiting-on-review Waiting on review from a Ruffle team member labels Dec 14, 2025
@moulins
Copy link
Contributor

moulins commented Dec 16, 2025

The playerglobals.swf shows the attributes as being:

  • DONT_ENUM, DONT_DELETE for StageCapture;
  • DONT_ENUM, DONT_DELETE, READ_ONLY for ActionGenerator and Configuration.

Is the discrepancy intentional?

@kjarosh kjarosh force-pushed the avm1-sutomation-stub branch from d0882ce to 001e2f6 Compare December 16, 2025 16:48
@kjarosh
Copy link
Member Author

kjarosh commented Dec 16, 2025

Hmmm, I thought the attributes were already tested; I'll take a look later

@kjarosh kjarosh added waiting-on-author Waiting on the PR author to make the requested changes and removed waiting-on-review Waiting on review from a Ruffle team member labels Dec 16, 2025
@kjarosh kjarosh force-pushed the avm1-sutomation-stub branch from 001e2f6 to 8e41ae9 Compare December 18, 2025 09:30
@kjarosh
Copy link
Member Author

kjarosh commented Dec 21, 2025

The playerglobals.swf shows the attributes as being:

* `DONT_ENUM, DONT_DELETE` for `StageCapture`;

* `DONT_ENUM, DONT_DELETE, READ_ONLY` for `ActionGenerator` and `Configuration`.

Is the discrepancy intentional?

@moulins I'm not sure if that's what you're referring to, but playerglobals.swf do not actually set these flags. It looks like they made a mistake, because

  1. for StageCapture the flags are set for StageCapture's prototype (o is not being assigned properly), and
  2. ASSetPropFlags(ActionGenerator,null,7); and ASSetPropFlags(Configuration,null,7); do nothing, because ActionGenerator and Configuration are undefined.

And as mentioned above, these things are tested, so I just made sure the flags are set the same way as observed in tests.

@kjarosh kjarosh force-pushed the avm1-sutomation-stub branch from 8e41ae9 to d9bc879 Compare December 21, 2025 21:23
@kjarosh kjarosh added waiting-on-review Waiting on review from a Ruffle team member and removed waiting-on-author Waiting on the PR author to make the requested changes labels Dec 21, 2025
@kjarosh kjarosh requested a review from moulins December 21, 2025 21:24
This patch stubs:
* flash.automation.Configuration,
* flash.automation.ActionGenerator,
* flash.automation.StageCapture.
@kjarosh kjarosh force-pushed the avm1-sutomation-stub branch from d9bc879 to 7def377 Compare December 26, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-avm1 Area: AVM1 (ActionScript 1 & 2) T-compat Type: Compatibility with Flash Player waiting-on-review Waiting on review from a Ruffle team member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants