avm2: Fix behavior when loaded MovieClip throws error in constructor #22569
+101
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ete` This makes it clearer what it's doing
In Flash, when this happens, the MovieClip isn't added as a child to the `Loader`, the `init` and `complete` events aren't fired, and the `contentLoaderInfo` becomes inaccessible.
Member
|
Shouldn't we e.g. propagate the error and let the code handle it more "naturally" than setting a flag and just changing behavior here and there? |
Collaborator
Author
|
@kjarosh The error appears in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Flash, when this happens, the MovieClip isn't added as a child to the
Loader, theinitandcompleteevents aren't fired, and thecontentLoaderInfobecomes inaccessible.