refactor: replace emoji with SF Symbol in UI components #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the UI to use SF Symbols instead of emojis for improved visual consistency. Adds canvas preview support to PromotionBadge.
…oggle labels Enhances UI with system images for clarity Replaces text-based symbols with system images in the UI to improve clarity and visual consistency. This change affects the "Hide Indicator" toggle and keyboard restore strategy options, providing a more intuitive user experience.
Owner
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on replacing emoji-based UI elements with SF Symbols for better consistency and accessibility across the application, along with some minor refactoring and enhancements. The most significant changes include updating various components to use
Image(systemName:)for icons, introducing a reusableToggleLabelcomponent, and adding a preview for thePromotionBadgecomponent.fixed #26
UI Updates with SF Symbols:
BrowserRuleEditView, usingImage(systemName:)for the "Hide Indicator" toggle.BrowserRuleRowto use SF Symbols for "Hide Indicator" and keyboard restore strategy icons, with dynamic colors based on the symbol type.PromotionBadgebuttons to useLabelwith SF Symbols for "Share with friends," "Star on GitHub," and "Sponsor" actions. Added a preview for the badge.Component Enhancements:
ToggleLabelcomponent inRulesApplicationDetail.swiftfor consistent label formatting with icons and text.ApplicationDetailto useImage(systemName:)for keyboard restore strategy and "Hide Indicator" toggles, replacing emojis. [1] [2] [3]Refactoring:
emojiproperty inKeyboardRestoreStrategywith asystemImageNameproperty to align with the SF Symbols migration.ApplicationPickerto use SF Symbols for various indicators such as "Hide Indicator," "Enhanced Mode Prompt," and keyboard restore states.Asset Update:
FakeDesktop.imagesetasset to useSequoia Graphic.pnginstead ofMonterey Graphic.jpg.