fix(uninstall): clean up Hermes skills and cron job - #114
Merged
Conversation
ADD-SP
force-pushed
the
add_sp/fix-uninstall
branch
2 times, most recently
from
April 12, 2026 04:51
49a9339 to
3bee867
Compare
The uninstall function cleaned up OpenClaw skills and cron but had zero Hermes cleanup — skill dirs under ~/.hermes/skills/ were left behind and the clawshell-weekly-stats cron job kept firing (and failing) after uninstall. - Discover Hermes skill dirs for both get-clawshell-stats and get-email-messages via resolve_hermes_target_user, list them in the uninstall preview, and remove with confirmation. - Best-effort `hermes cron remove clawshell-weekly-stats` when any Hermes skills were found. - Remove #[allow(dead_code)] from remove_hermes_stats_cron now that it has a non-test caller.
ADD-SP
force-pushed
the
add_sp/fix-uninstall
branch
from
April 12, 2026 04:54
3bee867 to
eca63c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The uninstall function cleaned up OpenClaw skills and cron but had zero Hermes cleanup — skill dirs under ~/.hermes/skills/ were left behind and the clawshell-weekly-stats cron job kept firing (and failing) after uninstall.
hermes cron remove clawshell-weekly-statswhen any Hermes skills were found.