fix(cli): log warnings when chmod/chown fails during onboard - #12
Merged
Merged
Conversation
Previously, permission-setting errors during onboard were silently ignored. These operations are security-critical, so failures should at least be logged as warnings for debugging purposes.
ADD-SP
approved these changes
Feb 14, 2026
chmod/chown fails during onboard
ADD-SP
enabled auto-merge
February 14, 2026 07:31
chmod/chown fails during onboardchmod/chown fails during onboard
ADD-SP
disabled auto-merge
February 14, 2026 07:32
ADD-SP
enabled auto-merge
February 14, 2026 07:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
chmod/chowncommands fail during onboardlet _ = ...Why
These permission-setting operations are security-critical. While the onboard process may still succeed, failures should be logged for debugging and auditing purposes.
Changes
src/main.rs: Replace silent error ignoring withwarn!()logsTest plan