Verbose validation error message#296
Merged
yuhr merged 6 commits intoruntypes:masterfrom Aug 11, 2022
Merged
Conversation
|
Any traction on this PR? |
Contributor
Author
|
I would also like to know if this will get merged 😞 |
Contributor
|
I've been using this personally because of how bad the error is. import { ValidationError } from 'runtypes';
import type { RuntypeBase } from 'runtypes/lib/runtype';
export const validateRunType = <T = unknown>(runType: RuntypeBase, data: T): T => {
try {
return runType.check(data) as T;
} catch (error: unknown) {
if ((error as ValidationError).details) throw new Error(JSON.stringify((error as ValidationError).details));
throw error;
}
}; |
Member
|
I'm very sorry for being unresponsible for a long time. Now I've got some time to work here. |
9332157 to
ca71bcd
Compare
This was
linked to
issues
Aug 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #260 - validation error messages should surface the incorrect fields without requiring extra error handling.
Previously:
Expected [number, { name: string; }], but was incompatibleNow: