Remove lockfile #46
Merged
Remove lockfile #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this is a library crate, we do not want the Cargo.lock in the repository. Signed-off-by: Matthias Beyer <[email protected]>
Signed-off-by: Matthias Beyer <[email protected]>
|
@philippkeller it seems that reviews are required. Can you please disable them? This setting can be managed automatically by bors, if you want to keep this setting (I can file a PR for enabling this with bors)! |
petreeftime
approved these changes
Sep 11, 2022
|
@matthiasbeyer sorry, didn't see this before. I don't see where I can disable this? |
|
It's the "require approvals" setting.
|
|
bors single on |
|
Build succeeded: |
|
@philippkeller Just to make sure you do not miss this: This PR was merged, but the setting is still not disabled. |
|
@matthiasbeyer I just changed the setting now, can you check again? Thanks so much for everything. This project has never been so active ever 🎉 |
|
@philippkeller yes looks alright now. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.