odb: fix OdbReader read return value#1061
Merged
Merged
Conversation
git_odb_stream_read return the number of bytes read.
Contributor
|
Thanks! I believe this is correct, but the libgit2 docs say it returns 0. I believe the docs are incorrect, so I opened libgit2/libgit2#6837 just to verify. |
ehuss
approved these changes
Jun 25, 2024
Contributor
ehuss
left a comment
There was a problem hiding this comment.
Looks like upstream got merged. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git_odb_stream_read return the number of bytes read.
This should be a typo, and will cuase Read.read_to_end to read for ever since it will continuously call
readto append more data to buf untilreadreturns eitherOk(0)or an error of non-ErrorKind::Interrupted kind.