feat: add Repository::refdb_compress() for packing loose refs#1221
Merged
Conversation
90fdb8a to
e8dd7d5
Compare
ehuss
reviewed
Mar 9, 2026
| assert!(repo.references_glob("refs/tags/test-*").unwrap().count() == 20); | ||
|
|
||
| // Compress should pack them without error. | ||
| repo.refdb_compress().unwrap(); |
Contributor
There was a problem hiding this comment.
Would it make sense to check the file packed-refs does not exist before calling this, and then check that it is created afterwards?
Contributor
Author
There was a problem hiding this comment.
Thanks for that - good shout.
I've added a check for that.
ehuss
approved these changes
Mar 9, 2026
Contributor
There was a problem hiding this comment.
Thanks!
As a longer-term alternative, another consideration would be to have a separate Rust type for a refdb and have compress be a method on it. However, since compress is currently the only thing you can do with it, it seems fine to have a convenience method for it on Repository.
Contributor
Author
|
@ehuss thanks for taking a look at this and providing a review Was a very positive and easy experience Happy to noodle on that idea you had |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wraps libgit2's
git_refdb_compress()as a safe Rust method on Repository.Link: https://libgit2.org/docs/reference/main/refdb/git_refdb_compress.html
Motivation:
Repositories with many loose refs (e.g. thousands of tags or identity refs) suffer degraded fetch and clone performance.
This exposes libgit2's ref packing capability so callers can compact loose refs into packed-refs without shelling out to git.