Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump libgit2 to 1.4.0#806

Merged
alexcrichton merged 2 commits into
rust-lang:masterfrom
dtolnay-contrib:bump
Feb 15, 2022
Merged

Bump libgit2 to 1.4.0#806
alexcrichton merged 2 commits into
rust-lang:masterfrom
dtolnay-contrib:bump

Conversation

@dtolnay
Copy link
Copy Markdown
Member

@dtolnay dtolnay commented Feb 15, 2022

Closes #804.

Comment thread src/lib.rs
pub use crate::refspec::Refspec;
pub use crate::remote::{
FetchOptions, PushOptions, Refspecs, Remote, RemoteConnection, RemoteHead,
FetchOptions, PushOptions, Refspecs, Remote, RemoteConnection, RemoteHead, RemoteRedirect,
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API question: RemoteRedirect or Redirect? The libgit2 enum is called git_remote_redirect_t.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think following libgit2 with RemoteRedirect is fine here

Copy link
Copy Markdown
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@alexcrichton alexcrichton merged commit 509fe58 into rust-lang:master Feb 15, 2022
@ehuss
Copy link
Copy Markdown
Contributor

ehuss commented Feb 15, 2022

Would it be possible to bump the version probe here?

@dtolnay dtolnay deleted the bump branch February 15, 2022 17:26
@extrawurst
Copy link
Copy Markdown
Contributor

@ehuss @alexcrichton yeah lets bump that before we mark a release please

@extrawurst
Copy link
Copy Markdown
Contributor

we probably need a release checklist in the readme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump libgit2 to 1.4.0

4 participants