Bind git_submodule_repo_init#914
Merged
Merged
Conversation
Hyask
pushed a commit
to tetrane/checkout
that referenced
this pull request
Jan 18, 2023
…tory Following rust-lang/git2-rs#914, we can now use `repo_init`, which gives us a real repository that we can clone to populate it.
Contributor
|
Thanks, can you add a test for it? |
Author
I thought about it, but after a quick look at the end of |
Contributor
|
Yea, I think it would go at the bottom of |
Author
|
I've added a test, do you think it's enough, or is more needed? |
Author
|
@ehuss thanks for the quick review and the merge. Do you have any idea when this will be released in a tag? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows a real initialization of a submodule's repository, where
git_submodule_initonly leaves you with nothing truly usable.