Add missing definitions for QNX8 for several BPF-related structures and constants#4769
Conversation
f1b2a57 to
7d27d60
Compare
|
This looks fine to me, cc target maintainers @flba-eb @gh-tr @jonathanpallant @japaric to verify things build |
tgross35
left a comment
There was a problem hiding this comment.
Would you actually mind moving this to the src/new module? We're slowly starting to migrate things there since it's easier to match up with what a user can #include. I believe this would be src/new/nto/net/if.h and src/new/nto/net/bpf.h, unless nto has a different structure. You can either move the existing BPF items over or not, your call.
Then this update to src/new/nto/mod.rs:
pub(crate) mod net {
pub(crate) mod route;
}And at
Lines 171 to 186 in 564e0ef
After that and the __c_anonymous_ifc_ifcu removal I'll merge this given we haven't heard back from the maintainers but this is straightforward.
Can you usually |
7d27d60 to
f62f2d4
Compare
This comment has been minimized.
This comment has been minimized.
@tgross35 Moved structs to Sorry for the delay in fixing this! I was away for a bit. |
879b73f to
1687b82
Compare
tgross35
left a comment
There was a problem hiding this comment.
Few small requests and one question. Would you be able to rebase? I think the test errors should be fixed
|
Reminder, once the PR becomes ready for a review, use |
1687b82 to
400b741
Compare
This comment has been minimized.
This comment has been minimized.
c244d16 to
414d82d
Compare
This comment has been minimized.
This comment has been minimized.
|
@rafaeling could you please squash the commits? I think this should be good to go once you do, unless @flba-eb wants to take another look. |
LGTM, thanks. |
414d82d to
d5e7444
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
d5e7444 to
9fb8e02
Compare
(backport <rust-lang#4769>) (cherry picked from commit 7634492)
Description
These structures are required for working with BPF filters and network interfaces on the QNX8 platform. Their absence currently prevents building or using BPF-related functionality with libc on QNX8 targets.
QNX Network Stack Versioning:
io-pktstack:io-sockstack:Sources
Updated
src/new/*accordinglyChecklist
libc-test/semverhave been updated-> No tests for QNX?
*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget); especially relevant for platforms that may not be checked in CI.-> even main branch does not work.
Error: could not execute process
/home/user/libc/target/x86_64-pc-nto-qnx800/debug/deps/libc-67e46525c5118905(never executed)