Thanks to visit codestin.com
Credit goes to github.com

Skip to content

remove dependency on reverted const type id #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2020
Merged

remove dependency on reverted const type id #419

merged 1 commit into from
Oct 15, 2020

Conversation

KodrAus
Copy link
Contributor

@KodrAus KodrAus commented Oct 15, 2020

We were going to depend on const_type_id, but that feature was reverted before it was stabilized.

I'm working on a refactoring that changes this, but in the meantime anybody depending on kv_unstable and building on 1.47.0 is broken. This just removes the expectation that 1.47.0 will allow const_type_id.

@KodrAus KodrAus merged commit 7a42b05 into master Oct 15, 2020
@KodrAus KodrAus deleted the KodrAus-patch-1 branch October 15, 2020 07:58
@KodrAus KodrAus mentioned this pull request Oct 15, 2020
Merged
@KodrAus KodrAus mentioned this pull request Dec 23, 2020
Merged
@Karrq
Copy link

Karrq commented Jan 8, 2021

Is this perhaps the expected error to find on 1.47?
I'm currently trying to investigate who enables the kv feature in my workspace

error[E0635]: unknown feature `const_type_id`
 --> /home/user/.cargo/registry/src/github.com-1ecc6299db9ec823/value-bag-1.0.0-alpha.5/src/lib.rs:3:54
  |
3 | #![cfg_attr(value_bag_capture_const_type_id, feature(const_type_id))]
  |                                                      ^^^^^^^^^^^^^

error: aborting due to previous error

For more information about this error, try `rustc --explain E0635`.
error: could not compile `value-bag`.

EFanZh pushed a commit to EFanZh/log that referenced this pull request Jul 23, 2023
@github-actions
release: binstalk v0.2.2 (rust-lang#419)
20ef463 
(cargo-release) version 0.2.2

Co-authored-by: github-actions <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
structured-logging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KodrAus @Karrq