Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#322 redux
Arguments for this change:
Mask<i32, 4>
overSimd<f32, 4>
only maps to one type of implementation.Mask<f32, 4>
just means "a mask over f32s"T::Mask
disappears from everywhere exceptMask::to_simd
/Mask::from_simd
.MaskElement
is removed from the public API.This comment from @thomcc summarizes the arguments against this change in the previous PR: #322 (comment)
From
implementations for all masks. Additionally,Select
was changed in Remove poor-performing bitmasks, add Select trait, and enable select on integer bitmasks #482 to allow any mask to select any vector as long as it has the same number of elements. Some code will require slightly more callsinto()
/cast()
in some situations but otherwise there should be minimal overhead.T: SimdElement
and that will also be your mask type.