Document RFC 1940 (must_use on fns) #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alercah
approved these changes
Feb 20, 2018
src/attributes.md
Outdated
| } | ||
| ``` | ||
|
|
||
| #### Must Use Attribute |
There was a problem hiding this comment.
I'd change this to "must_use Attribute"
src/attributes.md
Outdated
| # impl MustUse { | ||
| # fn new() -> MustUse { MustUse {} } | ||
| # } | ||
|
|
There was a problem hiding this comment.
Add a # to the start of one of these blank lines to avoid two in the rendered text.
3 tasks
|
Updated for behaviour with trait objects. Travis failure is in building mdbook? |
That's... odd |
|
I added a commit that just added a space and then had Travis test it. It passed. I then deleted that commit and it went back to the previous status of not passing because of whatever mysterious error we had last time. So if anybody wants to merge this, it's ready for merging. |
|
Travis will probably rebuild if you rebase on master? |
|
You are correct, and it now shows as passing. |
alercah
approved these changes
May 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the reference side of documenting this attribute — both the updates for the RFC and the original functionality. I do not think that this PR is sufficient documentation for stabilizing the feature, as I think the API guidelines should also be updated.