-
Notifications
You must be signed in to change notification settings - Fork 1.6k
async/await notation for ergonomic asynchronous IO #2394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
f63ddca
Async/await.
8c3d189
Fixed typos
regexident 7b43c7f
Merge pull request #4 from regexident/patch-1
7cfd755
Typo fix
aturon 411ad1f
Add async blocks
aturon 84c7edf
Rationale for async blocks
aturon 41ce201
Add more rationale for lazy async fn eval
aturon 15b6c9a
Update to match current futures APIs
aturon 822c24c
Grab keywords
aturon 685a588
Reorder async/move
aturon 32b748c
Fix typos
MajorBreakfast 0be451a
Explain use of initialization pattern
MajorBreakfast f43ad23
`?`-operator and control-flow constructs in async blocks
MajorBreakfast bcd934a
Ordering of async move keywords
MajorBreakfast 15c2de4
Rename `async for` to `for await`
MajorBreakfast 4059d72
RFC 2394 is async/await syntax.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Ordering of async move keywords
- Loading branch information
commit bcd934a59fc6c2c4f3b2e860c2a56aecbcf2b117
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should
move
go beforeasync
for consistency with closures?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagined that closures would also be written
async move |x| { ... }
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah, that's a different kind of consistency that may be more important? Overall as long as we have a consistent ordering everywhere I'm happy. (Just dealt with the lack of an enforced ordering in C++...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. We don't have const or unsafe closures so
async
would be first. I thinkasync move
,const move
,unsafe move
works nicely. πThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const unsafe async move |x| { ... }