Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add llvm_asm! and deprecate asm! #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 20, 2020
Merged

Add llvm_asm! and deprecate asm! #2843

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d5fe878
Add llvm_asm! and deprecate asm!
Amanieu Jan 4, 2020
088408a
Clarifications
Amanieu Jan 8, 2020
25dd57b
llvm_asm! is under the llvm_asm feature gate
Amanieu Feb 25, 2020
9911615
RFC 2843
Amanieu Mar 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
llvm_asm! is under the llvm_asm feature gate
  • Loading branch information
@Amanieu
Amanieu committed Feb 25, 2020
commit 25dd57bb44caf4dacd2be5c0623fcedb235614e4
4 changes: 2 additions & 2 deletions text/0000-llvm-asm.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ You should replace all uses of `asm!` with `llvm_asm!` in your code to avoid bre

All references to `asm!` inside the compiler will be changed to refer to `llvm_asm!` instead.
`asm!` will become a simple (deprecated) `macro_rules!` which redirects to `llvm_asm!`.
The deprecation warning will advise users that the semantics of `asm!` will change in the future and invite them to use `llvm_asm!` instead.
The deprecation warning will advise users that the semantics of `asm!` will change in the future and invite them to use `llvm_asm!` instead. The `llvm_asm!` macro will be guarded by the `llvm_asm` feature gate.

# Drawbacks
[drawbacks]: #drawbacks
Expand All @@ -59,7 +59,7 @@ for inline assembly, which allows direct access to variables in scope and does n
# Unresolved questions
[unresolved-questions]: #unresolved-questions

- Should the deprecated `asm!` macro be under the `asm` or `llvm_asm` feature gate?
None

# Future possibilities
[future-possibilities]: #future-possibilities
Expand Down