Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Command improvements for ergonomics and error handling #3362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Command improvements for ergonomics and error handling #3362

Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
2a26454
Propose Command improvements
ijackson Jan 5, 2021
9a4fc34
Apply rust tag to example
ijackson Jan 4, 2023
89705df
Discuss some alternatives around SubprocessError
ijackson Jan 4, 2023
38b9c2a
Add rust tags to many other code blocks
ijackson Jan 4, 2023
2ff775e
Use /nonexistent rather than /dev/enoent
ijackson Jan 13, 2023
71583a4
get_output gives one string, not a Vec
ijackson Jan 13, 2023
30a0106
get_output_line gives one string, not a Vec
ijackson Jan 13, 2023
36b59ca
Fix typo
ijackson Jan 13, 2023
57f63d7
Add lint suggestion to stderr handling default
ijackson Jan 13, 2023
bbd287d
Make SubprocessError be a transparent struct
ijackson Jan 13, 2023
79d0d25
Promote `just_status` to current proposed, from future
ijackson Jan 13, 2023
84e4c78
Rename to read_stdout_*
ijackson Jan 13, 2023
92ef0e7
Rename to ProcessError
ijackson Jan 13, 2023
d696820
Document behaviour of read_stdout_line with no output at all
ijackson Jan 13, 2023
024e8ca
Cross-reference for EOF and exit wait of read_stdout{,_line}
ijackson Jan 13, 2023
07ffa9f
Rename to ChildOutputStream
ijackson Jan 13, 2023
8e96f69
Move deprecation of .output() to Future possibilities
ijackson Jan 13, 2023
cd1c96d
Document Error impl cause() behaviour
ijackson Jan 13, 2023
80f1496
Discuss sensitive command line arguments
ijackson Jan 13, 2023
9d8a2a4
Discuss combine-and-interleave of stdout and stderr
ijackson Jan 13, 2023
e16f199
Use read_stdout for the bytes version
ijackson Jan 13, 2023
92ee567
Move read_stdout_line to Future possibilities
ijackson Jan 13, 2023
b8c623c
Make error fields pub
ijackson Jan 13, 2023
d94ad5d
Discuss status of the various ProcessError functions
ijackson Jan 13, 2023
ac61312
Make SubprocessError not be Clone
ijackson Jan 13, 2023
732e555
Propose adding a docs warning to Command.output()
ijackson Jan 13, 2023
2292b56
Fix typo
ijackson Jan 19, 2023
9167ef5
Expand on reasoning for ProcessError::Default
ijackson Jan 19, 2023
561cb3f
Do a missed rename
ijackson Jan 19, 2023
0103012
Slightly weaken assertion about stdout/stderr demux
ijackson Jan 19, 2023
efa40c2
Add note about portability to comments about command lines
ijackson Jan 19, 2023
37c4699
Expand on examples of why we want external ProcessError construction
ijackson Jan 19, 2023
3f8db6e
Introduce other_error replacing communication_error
ijackson Jan 19, 2023
a967e0f
Introduce other_error replacing communication_error (clarify)
ijackson Jan 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add lint suggestion to stderr handling default 
Co-authored-by: Josh Triplett <[email protected]>
  • Loading branch information
@ijackson @joshtriplett
ijackson and joshtriplett authored Jan 13, 2023
commit 57f63d77236d77dc8ab07e00faddced08189e76b
2 changes: 2 additions & 0 deletions text/0000-command-ergonomics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,8 @@ Options are:
to all the new methods.
These seem unpalatably unergonomic.

5. One of the above, and additionally provide a lint that makes a best-effort attempt to catch this at compile time.

Here we propose option 1: treat as `inherit`.

# Future possibilities
Expand Down